Throw specific exceptions with common parent class#27
Merged
matthi4s merged 1 commit intoaternosorg:masterfrom Sep 22, 2025
Merged
Throw specific exceptions with common parent class#27matthi4s merged 1 commit intoaternosorg:masterfrom
matthi4s merged 1 commit intoaternosorg:masterfrom
Conversation
matthi4s
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
@throws \Exceptionphpdoc tags with individual exception classes that extendModelException.ModelExceptionis also aRuntimeExceptionbecause handling these exceptions should not be expected, and IDEs won't complain when you don't handle them explicitly.